Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 and DataAccessAuthMode feature for Compute cmdlets #18131

Merged
merged 5 commits into from
May 13, 2022

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented May 12, 2022

Description

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1165

Adding [-Architecture ] for
New-AzDiskConfig
New-AzDiskUpdateConfig
New-AzSnapshotConfig
New-AzSnapshotUpdateConfig
New-AzGalleryImageDefinition

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1142
Add -DataAccessAuthMode parameter to the following cmdlets:
- New-AzDiskConfig
- New-AzDiskUpdateConfig
- New-AzSnapshotConfig
- New-AzSnapshotUpdateConfig

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@grizzlytheodore grizzlytheodore changed the title Add Arm64 feature for Compute cmdlets Add Arm64 and DataAccessAuthMode feature for Compute cmdlets May 12, 2022
* add -DataAccessAuthMode to Snaptshot/Disk config/updateConfig

* trying DataAuth in Add-AzVhd

* progress save for Add-AzVhd

* remove add-azvhd stuff

* md files
@wyunchi-ms wyunchi-ms merged commit e6a6ae8 into main May 13, 2022
@grizzlytheodore grizzlytheodore deleted the feature/cplat-arm64 branch May 20, 2022 21:51
azure-sdk pushed a commit to azure-sdk/azure-powershell that referenced this pull request Jun 8, 2022
[Hub Generated] Review request for Microsoft.Marketplace to add version stable/2022-03-01 (Azure#18131)

* clone 2021-12-01 to 2022-03-01

* update api-version 2022-03-01 prop

* 20220301_ver1

* fix examples

* Adds base for updating Microsoft.Marketplace from version stable/2021-12-01 to version 2022-03-01

* Updates readme

* Updates API version in new specs and examples

* Edit decriptions & change schemas

* Change responses for ApproveAllItems & disableApproveAllItems;

* UpsertOfferWithMultiContext

* Marketplace prettier fix

* Fix: spell, order, type

* Schemas changes

* MultiContextAndPlansProperties - add props

* Fix QueryUserOffersProperties

* MultiContextAndPlansProperties - add properties

* improve description and add date-time format

* improve description and add date-time format

* QueryApprovedPlans Object - support multi context

* PrivateStore_AnyActiveOffer

* spell fix

* Rename to AnyExistingOffersInTheStore

* Change desc

* rename to AnyExistingOffersInTheCollections

* Add icon prop to AdminRequestApprovalProperties 2021-12-01

* Revert latest commit

* Revert 'Add icon prop to AdminRequestApprovalProperties 2021-12-01'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants